Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #111009: Windows: ensure runAsNonRoot does case-insensitive comparison #112213

Merged
merged 2 commits into from Sep 7, 2022
Merged

Automated cherry pick of #111009: Windows: ensure runAsNonRoot does case-insensitive comparison #112213

merged 2 commits into from Sep 7, 2022

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Sep 2, 2022 •
edited

Cherry pick of #111009 on release-1.22.

#111009: Windows: ensure runAsNonRoot does case-insensitive comparison

For details on the cherry pick process, see the cherry pick requests page.

UserName check for 'ContainerAdministrator' is now case-insensitive if runAsNonRoot is set to true on Windows.

@marosset @PushkarJ
Windows: ensure runAsNonRoot does case-insensitive comparison on user…
ef4cc21 
… name

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Sep 2, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 2, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 2, 2022
@marosset
Copy link
Contributor

marosset commented Sep 2, 2022

/release-note UserName check for 'ContainerAdministrator' is now case-insensitive if runAsNonRoot is set to true on Windows.
/triage accepted
/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 2, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2022
@PushkarJ
Copy link
Member Author

PushkarJ commented Sep 3, 2022

/label tide/merge-method-squash

(To ensure commits are squashed before merge)

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 3, 2022
@marosset
Copy link
Contributor

marosset commented Sep 6, 2022

/assign @jeremyrickard @Verolop

@marosset
Copy link
Contributor

marosset commented Sep 6, 2022

/release-note-edit UserName check for 'ContainerAdministrator' is now case-insensitive if runAsNonRoot is set to true on Windows.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 6, 2022
@dims
Copy link
Member

dims commented Sep 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mrunalp, PushkarJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@PushkarJ
Copy link
Member Author

PushkarJ commented Sep 7, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 7, 2022
@jeremyrickard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@puerco
Copy link
Member

puerco commented Sep 7, 2022

/lgtm
Thanks @PushkarJ !

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 7, 2022
@marosset
Copy link
Contributor

marosset commented Sep 7, 2022

/retest

@puerco
Copy link
Member

puerco commented Sep 7, 2022

Timed out again
/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot merged commit 6b45bdd into kubernetes:release-1.22 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@ksubrmnn ksubrmnn Awaiting requested review from ksubrmnn

Assignees

@Verolop Verolop

@puerco puerco

@marosset marosset

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@PushkarJ @marosset @dims @k8s-ci-robot @jeremyrickard @puerco @mrunalp @Verolop